feat(APP-604): Add new SelectAddress component for asset selection by milosh86 · Pull Request #1143 · aragon/app

milosh86 · 2026-05-20T14:13:39Z

Description

Introduces a new AssetAddressSelect component replacing the existing AssetSelectionDialog flow in AssetInput. Users can now pick a token from the DAO's asset list, search by name/symbol/address, or add a custom token by entering its address (resolved on the fly via RPC).

Linear: APP-604

Highlights

New AssetAddressSelect component with paginated list, search, and "add by address" flow
Subcomponents: AssetAddressSelectItem, AssetAddressSelectAddAddressView, AssetAddressSelectAddButton, AssetAddressSelectBackButton, AssetAddressSelectEmptyState
Search by name, symbol, or address; auto-resolves addresses immediately when the query is an address
AssetInput updated to use the new selector and to flip the max-amount layout per design
Token symbol/logo fallbacks tightened in AssetInputToken
Bumps @aragon/gov-ui-kit to use the new DataListItem select variant

Type of Change

Major: Breaking change (change that would cause existing functionality to not work as expected)
Minor: Feature (non-breaking change which adds new functionality)
Patch: Enhancement (non-breaking change to an existing feature)
Patch: Bug fix (non-breaking change which fixes an issue)

Developer Checklist:

Review Checklist:

(For User Stories only) Tested in a preview or locally that all Acceptance Criteria are satisfied
Confirmed that changes follow the code style guidelines of this project

Signed-off-by: Milos Dzepina <milos@aragon.org>

linear-code · 2026-05-20T14:13:43Z

APP-604

github-actions · 2026-05-20T14:16:41Z

🚀 Preview Deployment: View Here

github-actions · 2026-05-20T14:21:18Z

E2E results (preview)

Smoke


Base URL	https://app-next-hpx0xa2cv-aragon-app.vercel.app
Suite	smoke
Playwright result	✅ passed
Summary	75 passed, 5 skipped
HTML report	View report
GitHub job	✅ completed

View run #4219

Signed-off-by: Milos Dzepina <milos@aragon.org>

thekidnamedkd

Looking good. Couple questions. 🧑‍🚀

thekidnamedkd · 2026-05-20T19:18:09Z

@@ -0,0 +1,35 @@
+import { IconType } from '@aragon/gov-ui-kit';


I don't remember this pattern. It's sort of like hook/util as component? Naming and location seems off maybe.

right, I was on the fence when I saw it and I just let it go, but you are right, no need to have a different pattern for the same thing we already have in other places.

.... I just inlined empty state as it's passed as a prop

thekidnamedkd · 2026-05-20T19:20:21Z


        const pluginSetupRef = {
-            pluginSetupRepo,
+            pluginSetupRepo: pluginSetupRepo as Hex,


Do we need to cast?

this was strange, I don't know why I've got this TS error, I didn't change anything related .... I'll double check, maybe just some TS cache issue

could you please check if you get this TS error in main? I do, and I don't know how we got around it before...

Signed-off-by: Milos Dzepina <milos@aragon.org>

milosh86 · 2026-05-22T08:34:26Z

@thekidnamedkd there is also an additional govkit PR related to this one, so we need a release before merging

Signed-off-by: Milos Dzepina <milos@aragon.org>

thekidnamedkd

Did a closer pass — overall this is shaping up nicely. A few things worth a look, the biggest being the decimals fallback on the Unknown asset row, which I think will throw downstream in the transfer flow.

Signed-off-by: Milos Dzepina <milos@aragon.org>

thekidnamedkd

LGTM 🔥

milosh86 added 9 commits May 18, 2026 17:05

Add assetAddressSelect basic - WIP

c02b0fc

Signed-off-by: Milos Dzepina <milos@aragon.org>

Add empty state

0ca784c

Signed-off-by: Milos Dzepina <milos@aragon.org>

Add manual address select

ae50acf

Signed-off-by: Milos Dzepina <milos@aragon.org>

Implement search

a527251

Signed-off-by: Milos Dzepina <milos@aragon.org>

Fine tuning

1691c55

Signed-off-by: Milos Dzepina <milos@aragon.org>

Fine tuning

a282708

Signed-off-by: Milos Dzepina <milos@aragon.org>

Update assetInput

fa60448

Signed-off-by: Milos Dzepina <milos@aragon.org>

Fix tests

e349fbd

Signed-off-by: Milos Dzepina <milos@aragon.org>

Use ui-kit snapshoot

377d013

Signed-off-by: Milos Dzepina <milos@aragon.org>

milosh86 temporarily deployed to preview May 20, 2026 14:13 — with GitHub Actions Inactive

milosh86 commented May 20, 2026

View reviewed changes

Comment thread src/modules/finance/components/assetAddressSelect/assetAddressSelectAddAddressView.tsx Outdated

milosh86 added 2 commits May 20, 2026 16:29

Merge branch 'main' into app-604-new-selectaddress-component

509c8e3

Add changeset

1de4e64

Signed-off-by: Milos Dzepina <milos@aragon.org>

milosh86 temporarily deployed to preview May 20, 2026 14:30 — with GitHub Actions Inactive

milosh86 added 2 commits May 20, 2026 16:33

Fix lint

a3a7204

Signed-off-by: Milos Dzepina <milos@aragon.org>

Fix type-check

c14312f

Signed-off-by: Milos Dzepina <milos@aragon.org>

milosh86 temporarily deployed to preview May 20, 2026 14:38 — with GitHub Actions Inactive

Update ui-kit

a403334

Signed-off-by: Milos Dzepina <milos@aragon.org>

milosh86 marked this pull request as ready for review May 20, 2026 18:15

milosh86 requested a review from a team as a code owner May 20, 2026 18:15

Merge branch 'main' into app-604-new-selectaddress-component

bbf63f5

milosh86 temporarily deployed to preview May 20, 2026 18:19 — with GitHub Actions Inactive

thekidnamedkd reviewed May 20, 2026

View reviewed changes

milosh86 added 2 commits May 21, 2026 17:23

Refactor add and back buttons

76cc6d5

Signed-off-by: Milos Dzepina <milos@aragon.org>

Fix tests

d8d8efa

Signed-off-by: Milos Dzepina <milos@aragon.org>

milosh86 temporarily deployed to preview May 21, 2026 15:46 — with GitHub Actions Inactive

Remove emptyState util

705937d

Signed-off-by: Milos Dzepina <milos@aragon.org>

milosh86 temporarily deployed to preview May 22, 2026 08:33 — with GitHub Actions Inactive

milosh86 requested a review from thekidnamedkd May 22, 2026 08:33

If imported address has no symbol fallback to truncated address

35de112

Signed-off-by: Milos Dzepina <milos@aragon.org>

milosh86 temporarily deployed to preview May 22, 2026 09:36 — with GitHub Actions Inactive

Merge branch 'main' into app-604-new-selectaddress-component

4991043

milosh86 temporarily deployed to preview May 22, 2026 10:15 — with GitHub Actions Inactive

thekidnamedkd reviewed May 25, 2026

View reviewed changes

milosh86 added 3 commits May 25, 2026 14:36

Merge branch 'main' into app-604-new-selectaddress-component

2699d70

Update ui-kit

e49b157

Signed-off-by: Milos Dzepina <milos@aragon.org>

Address PR comments

1b80946

Signed-off-by: Milos Dzepina <milos@aragon.org>

milosh86 temporarily deployed to preview May 25, 2026 13:20 — with GitHub Actions Inactive

milosh86 requested a review from thekidnamedkd May 25, 2026 13:30

thekidnamedkd approved these changes May 26, 2026

View reviewed changes

milosh86 merged commit b4f77d4 into main May 26, 2026
17 checks passed

milosh86 deleted the app-604-new-selectaddress-component branch May 26, 2026 08:39

		@@ -0,0 +1,35 @@
		import { IconType } from '@aragon/gov-ui-kit';

Conversation

milosh86 commented May 20, 2026

Description

Highlights

Type of Change

Developer Checklist:

Review Checklist:

Uh oh!

linear-code Bot commented May 20, 2026

Uh oh!

github-actions Bot commented May 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented May 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

thekidnamedkd left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

thekidnamedkd May 20, 2026

Choose a reason for hiding this comment

Uh oh!

milosh86 May 21, 2026

Choose a reason for hiding this comment

Uh oh!

milosh86 May 22, 2026

Choose a reason for hiding this comment

Uh oh!

thekidnamedkd May 20, 2026

Choose a reason for hiding this comment

Uh oh!

milosh86 May 21, 2026

Choose a reason for hiding this comment

Uh oh!

milosh86 May 22, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

milosh86 commented May 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

thekidnamedkd left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

thekidnamedkd left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

github-actions Bot commented May 20, 2026 •

edited

Loading

github-actions Bot commented May 20, 2026 •

edited

Loading

milosh86 commented May 22, 2026 •

edited

Loading