fix(page-practice): debounce blur to prevent ad refresh resetting lesson#576
Open
faneb wants to merge 3 commits into
Open
fix(page-practice): debounce blur to prevent ad refresh resetting lesson#576faneb wants to merge 3 commits into
faneb wants to merge 3 commits into
Conversation
Changed Files
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #168 — third-party ad scripts briefly steal and return focus, which triggers
handleBlur→onResetLesson(), resetting the lesson mid-session.handleBlurnow delays the lesson reset by 300 ms. If focus returns within that window (as it does during an ad refresh),handleFocuscancels the pending timer and the lesson continues uninterrupted.handleBlurclears any existing timer before starting a new one, preventing multiple queued resets if blur fires rapidly. Timer is also cleaned up incomponentWillUnmount.PracticeScreen, simulates a transient blur/re-focus cycle, and asserts the lesson text is preserved.