fix(TextInput): update condition to check for forgiving errors in TextInput#487
Open
spike014 wants to merge 1 commit into
Open
fix(TextInput): update condition to check for forgiving errors in TextInput#487spike014 wants to merge 1 commit into
spike014 wants to merge 1 commit into
Conversation
|
Review changes with Changed Files
|
aradzie
force-pushed
the
master
branch
2 times, most recently
from
2bfdcb4 to
bc3a8a7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #321 #324
I've updated the tests, and they now pass, but I'm not 100% sure if my solution fully matches your expectations. Please feel free to point out any mistakes or suggest improvements.
Thanks again for this awesome website. I'm a big fan! Love it! ❤️ @aradzie