Skip to content

feat: SpeedChart plot visibility toggle#472

Open
uFloppyDisk wants to merge 6 commits into
aradzie:masterfrom
uFloppyDisk:feat/chart-plot-visibility-toggle
Open

feat: SpeedChart plot visibility toggle#472
uFloppyDisk wants to merge 6 commits into
aradzie:masterfrom
uFloppyDisk:feat/chart-plot-visibility-toggle

Conversation

@uFloppyDisk

@uFloppyDisk uFloppyDisk commented Jun 20, 2025

Copy link
Copy Markdown
Contributor

Implements feature request #283
Users can individually toggle visibility of speed, accuracy, and complexity scatter-plots by clicking the corresponding coloured markers under the "Typing Speed" chart or "solo" the given plot by hovering over the corresponding marker.

@semanticdiff-com

semanticdiff-com Bot commented Jun 20, 2025

Copy link
Copy Markdown

Review changes with  SemanticDiff

Changed Files
File Status
  packages/keybr-chart/lib/Marker.tsx  59% smaller
  packages/keybr-chart/lib/SpeedChart.tsx  44% smaller
  packages/page-profile/lib/profile/SpeedChartSection.tsx  40% smaller
  packages/keybr-chart/lib/Marker.module.less Unsupported file format

@aradzie aradzie force-pushed the master branch 2 times, most recently from 2bfdcb4 to bc3a8a7 Compare September 16, 2025 11:31
@uFloppyDisk

Copy link
Copy Markdown
Contributor Author

Hi @aradzie safely ignore this if busy.
I'm checking in on this PR as I believe this feature would be nice to have. I've been using keybr for a while now and my charts are starting to get cramped.

What do you think of this feature idea and my implementation?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant