Updated to add systematic errors switch and job scripts.#117
Merged
Conversation
marcomuzio
requested changes
Apr 17, 2026
Machtay
force-pushed
the
systematics_options
branch
from
3da49fb to
19183ec
Compare
marcomuzio
approved these changes
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Opening this PR preliminarily. This updates the table making cpp script to take a new option for using the systematic errors in AraSim. It also includes job scripts for npx that make the tables, though they have some hardcoding for my directories right now.
EDIT: Ok, these scripts work now and I used them to create new ray trace timing tables. I still have some hardcoding in here I needed to get this to run, but I can work on generalizing it.
EDIT 5/20/26: The systematic errors are now updated with new values. These values come from here: https://aradocs.wipac.wisc.edu/cgi-bin/DocDB/ShowDocument?docid=3525 (See the table at the end). The key here is that we found the systematics by looking at the different available ice models and varying the sources of error to encompass them all. See near line 110 in makeRTArrivalTables.cpp to compare the values.
Here is what we found by varying the values to encompass the entire set of ice models:
A: +0.008, -0.006
B: +0.08368, -0.16
C: +0.0004, -0.0047