fix: prevent GITHUB_TOKEN from overriding LGTM app token in refresh-library CI#95
Draft
souravbiswassanto wants to merge 3 commits into
Draft
fix: prevent GITHUB_TOKEN from overriding LGTM app token in refresh-library CI#95souravbiswassanto wants to merge 3 commits into
souravbiswassanto wants to merge 3 commits into
Conversation
…ibrary CI Signed-off-by: souravbiswassanto <saurov@appscode.com>
…licts Signed-off-by: souravbiswassanto <saurov@appscode.com>
Signed-off-by: souravbiswassanto <saurov@appscode.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
persist-credentials: falseto theactions/checkoutstep so the GITHUB_TOKEN credential helper (extraheader) is not installedgit remote set-urlline —url.insteadOfwith the LGTM app token is sufficientRoot Cause
actions/checkoutwith the defaultpersist-credentials: trueinstalls anhttp.https://github.com/.extraheaderthat injects theGITHUB_TOKENas an HTTPAuthorizationheader. This header takes precedence over URL-embedded credentials set viaurl.insteadOf, causinggit pushto authenticate asgithub-actions[bot](which lacks write permission) instead of the intended LGTM app token.Test plan
refresh-libraryworkflow manually viaworkflow_dispatchand verify the "Update repo" step pushes successfully🤖 Generated with Claude Code