Test minimum dependency bounds#103
Open
gselzer wants to merge 12 commits into
Open
Conversation
Member
|
@gselzer Thanks! I took a look at the requests source code; it seems that 2.16.0 is the first version that removed the vendored |
Contributor
Author
|
Thanks @ctrueden! Looks like we'll need an even newer version of |
Contributor
Author
|
How do you feel about the expansion of the matrix to test highest and lowest for both? We could |
gselzer
force-pushed
the
test-minimum-dependencies
branch
2 times, most recently
from
da52862 to
8df6bc7
Compare
Didn't realize that all of the dependency installation is actually happening here
Theoretically, everything we should need for the later steps should be handled within the shell scripts
Versions before 2.16.0 vendored `packages/urllib3/packages/six.py`, resulting in widespread failures of the form: ModuleNotFoundError: No module named 'urllib3.packages.six.moves'
We may have to binarysearch this :)
gselzer
force-pushed
the
test-minimum-dependencies
branch
from
8df6bc7 to
b49d22d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It'd be great to verify that jgo works with all of the dependency versions it claims to support. Of course, testing all combinations is infeasible, but we could test other combinations (namely, the minimum bound, in addition to the maximum bounds currently tested)
Note that this PR adds in a number of dependency bounds, namely:
psutil>=1- we just want a minimum bound, this one works despite being very old