Docs/typos and comment fixes#3
Merged
Merged
Conversation
Apply the mechanical-tier findings from the swift-tls style review:
- Misspellings: recieved (8 sites), transcipt (3), acces, elemnt,
offererd, CertificateMessag, nulTerminated cross-references.
- Rename receievedServerFinished -> receivedServerFinished and
update its single caller. Source-breaking; no deprecated alias.
- Fragments: "This exporter master secret" -> "This is the exporter
master secret" in three KeyScheduler sites.
- Doubled words: "to to" (twice), "the the signature".
- Punctuation: stray "(" in Clock.swift fatalError, trailing commas
after closing parens, trailing space in log string, comma -> period,
missing terminal periods, orphan //, double space and missing article
in README.
- Wording: "perform" -> "performing", "and" -> "an", "is await" ->
"is awaiting" (two files), "a the resumption psk" -> "the resumption
psk", "didnt" -> "didn't", "any" -> "and" in EmbeddedPrint, log
string "x25519-MLKEM768" -> "x25519MLKEM768" to match the canonical
type spelling.
- Log capitalization: "likely epsk" -> "Likely epsk", "aborting
handshake" -> "Aborting handshake".
- fragments, run-ons, passive voice, ambiguous pronouns, and contradictions - Reconcile the contradictory SwiftTLSOpaqueReferenceKey init and the supportsUnverifiedX509 list.
heckj
requested review from
agnosticdev,
baumanl,
ekinnear,
kpodosin and
tfpauly
as code owners
agnosticdev
reviewed
Jun 9, 2026
agnosticdev
left a comment
agnosticdev
left a comment
There was a problem hiding this comment.
Just one more change. Thank you for going through and fixing all of these!
agnosticdev
reviewed
Jun 9, 2026
tfpauly
reviewed
Jun 9, 2026
tfpauly
approved these changes
Jun 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A collection of fixes for typos, grammar, and adherence to Apple style guidelines for API and documentation content.