Skip to content

Don't crash on window adjust for a closed child channel #239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
andrewkomkov wants to merge 1 commit into
base: main
Choose a base branch
from
+10 −1
Open

Don't crash on window adjust for a closed child channel #239

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion Sources/NIOSSH/Child Channels/ChildChannelStateMachine.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -493,7 +493,16 @@ extension ChildChannelStateMachine {
// In the idle state we haven't either sent a channel open or received one. This is not really possible.
preconditionFailure("Somehow received channel EOF for idle channel")

case .requestedLocally, .requestedRemotely, .closedLocally, .closedRemotely, .closed:
case .closedLocally, .closedRemotely, .closed:
// A read can be delivered from the multiplexer's pending-read queue
// after the channel was closed; the resulting window adjust must not
// crash the process. Surface it as a protocol error instead.
throw NIOSSHError.protocolViolation(
protocolName: "channel",
violation: "Sent channel window adjust on closed channel."
)

case .requestedLocally, .requestedRemotely:
preconditionFailure("Sent channel window adjust on channel in invalid state")
}
}
Expand Down