Enable the embedded version of the libary#50
Merged
Conversation
This re-enables the 'BinaryParsingEmbedded' target, which builds from the same sources as the non-embedded version of the library. I've also added a basic "parser" to test that the library is usable.
natecook1000
force-pushed
the
re-enable-embedded
branch
from
January 7, 2026 00:41
49b3832 to
b3da44e
Compare
DougGregor
approved these changes
Jan 7, 2026
| name: "swift-binary-parsing", | ||
| platforms: [ | ||
| .macOS(.v13), .iOS(.v16), .watchOS(.v9), .tvOS(.v16), .visionOS(.v1), | ||
| .macOS(.v14), .iOS(.v17), .watchOS(.v10), .tvOS(.v17), .visionOS(.v1), |
Member
There was a problem hiding this comment.
Why did you need to bump these deployment targets back up? Were they wrong?
Member
Author
There was a problem hiding this comment.
With the embedded target added I get this error when I build locally:
<unknown>:0: error: compiling for macOS 13.0, but module 'Swift' has a minimum deployment target of macOS 14: /Users/nate/Library/Developer/Toolchains/swift-DEVELOPMENT-SNAPSHOT-2026-01-06-a.xctoolchain/usr/lib/swift/embedded/Swift.swiftmodule/arm64-apple-macos.swiftmodule
Member
There was a problem hiding this comment.
Drat. This undoes some of the improvement from #47. I don't know of a good way around it, though
Member
Author
There was a problem hiding this comment.
Ended up needing to conditionalize the embedded support anyway, so the platforms are reset in the default case! 🎉
The array parser that is available in non-embedded contexts has an untyped `throws` designation. This change allows for using typed throws with the array parser even on non-embedded platforms.
natecook1000
force-pushed
the
re-enable-embedded
branch
from
January 8, 2026 00:24
8cebed0 to
306b5f0
Compare
natecook1000
force-pushed
the
re-enable-embedded
branch
from
January 8, 2026 00:31
975adfc to
3337858
Compare
natecook1000
force-pushed
the
re-enable-embedded
branch
from
January 8, 2026 17:49
832946a to
3f9548f
Compare
natecook1000
force-pushed
the
re-enable-embedded
branch
5 times, most recently
from
January 8, 2026 20:18
00bf97d to
34c31a5
Compare
natecook1000
force-pushed
the
re-enable-embedded
branch
from
January 8, 2026 22:25
34c31a5 to
b65cec8
Compare
natecook1000
marked this pull request as ready for review
January 9, 2026 16:58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This re-enables the 'BinaryParsingEmbedded' target, which builds from the same sources as the non-embedded version of the library. I've also added a basic "parser" to test that the library is usable.