Use NDArrayDescriptor.resolvingDynamicDimensions instead of modifying NDArrayDescriptor.shape directly#74
Merged
blevine1 merged 1 commit intoJul 1, 2026
Conversation
stikves
approved these changes
Jul 1, 2026
blevine1
force-pushed
the
use-ndarraydescriptor-resolving-dynamic-dimensions
branch
from
8866f5c to
8892dcb
Compare
… NDArrayDescriptor.shape directly
blevine1
force-pushed
the
use-ndarraydescriptor-resolving-dynamic-dimensions
branch
from
8892dcb to
4bd0c6b
Compare
tjia1818
approved these changes
Jul 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The intended way to fill in the dynamic dimensions of a dynamic shape NDArrayDescriptor is to use
NDArrayDescriptor.resolvingDynamicDimensions(_:), which will check for validity of swapped shaped.This PR updates to use that API instead of mutating
NDArrayDescriptor.shapedirectly.