Dump GPU Optests#52
Closed
YifanShenSZ wants to merge 1 commit into
Closed
Conversation
YifanShenSZ
requested review from
DawerG,
Lewis300,
carinapeng,
gokulkrishna98,
stikves and
tjia1818
stikves
reviewed
Jun 17, 2026
| coreai_program: AIProgram, | ||
| asset_path: Path, | ||
| ) -> InferenceFunction: | ||
| from tests.conftest import get_test_specialization_options |
Contributor
There was a problem hiding this comment.
I don't think we should wire test code into production.
Can we try either:
A - Adding an optional "AssetDumper" structure that we pass here
B - Using decorations / patches at the test level to induce this behavior?
Contributor
|
stale for too long, closing for now. Feel free to re-open if needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dump op tests and run on non-CPU backends, similar to coreai-torch
Usage: In addition to our usual pytest
Add 2 optional args
--compute-unit-kind=gpu--dump-optestsTesting: Locally tested with