Fix potential integer math crash on PublishPort.#1612
Open
jglogan wants to merge 1 commit into
Open
Conversation
- Closes apple#1610. - Discovered, and originally filed as a security advisory, by PresidentL <131139636+liyander@users.noreply.github.com>. - `PublishPort` currently can store invalid combinations of starting port and range that can overflow UInt16 values when summed, crashing the process. - Updates `PublishPort` to validate inputs on initialization.
Code Coverage
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PublishPortcurrently can store invalid combinations of starting port and range that can overflow UInt16 values when summed, crashing the process.PublishPortto validate inputs on initialization.Type of Change
Motivation and Context
The problem only impacts the container application and not the system or other apps, and it requires sending raw publish ports through the container API server XPC interface as the standard client does validate inputs in the client utilities. Regardless, without proper validation it's possible to unintentionally or intentionally crash the apiserver with an XPC call.
Testing