Skip to content

Fix Xcode receipt parsing with strict ASN.1 lengths #419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kiwigitops wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix Xcode receipt parsing with strict ASN.1 lengths #419

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion receipt_utility.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ export class ReceiptUtility {
const oldResult = prevGetVblenFunction(s, idx)
// Round up to the remaining length in the string, measured in bytes (2 hex values per byte)
if (oldResult === 0 && c === '80') {
return (s.length - idx) / 2
return (s.length - ASN1HEX.getVidx(s, idx)) / 2
}
return oldResult
}
Expand Down