Добавлены API-тесты#1
Open
aporguneva wants to merge 1 commit into
Open
Conversation
klushcheva
reviewed
May 12, 2026
klushcheva
left a comment
klushcheva
left a comment
There was a problem hiding this comment.
✅ Сильные стороны:
- Код запускается без ошибок
- Написанные тесты атомарны, проверяется тело и код отчета, там где это необходимо
- Тестовые данные создаются перед тестом и удаляются после того, как он выполнится
| pytest | ||
| requests | ||
| Faker | ||
| python-dotenv |
There was a problem hiding this comment.
Можно лучше: использовать pip freeze для фиксации версий библиотек
| @allure.title("Ошибка при отсутствии почты") | ||
| @allure.description("Проверка, что система не позволяет создать пользователя при отсутствии обязательного поля email, система возвращает ошибку 403") | ||
|
|
||
| def test_create_missing_email(self, cleanup_user): |
There was a problem hiding this comment.
Можно лучше: этот тест параметризовать вместе с test_create_missing_password, так как логика одинаковая, отличие только в тестовых данных
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.