Skip to content

feat(gwca): scan-health logging to surface silently-broken pattern scans#29

Open
sch0l0ka-hash wants to merge 1 commit into
apoguita:mainfrom
sch0l0ka-hash:gwupdate-scan-logging
Open

feat(gwca): scan-health logging to surface silently-broken pattern scans#29
sch0l0ka-hash wants to merge 1 commit into
apoguita:mainfrom
sch0l0ka-hash:gwupdate-scan-logging

Conversation

@sch0l0ka-hash

Copy link
Copy Markdown
Contributor

After a GW client update a broken pattern scan resolves to null and the feature dies quietly with no log. This makes such failures visible:

  • GWCA.cpp: a [SCAN-HEALTH] summary after module init that re-emits every NULL scan / FAILED hook from the central registry into Py4GW_injection_log.txt.
  • +31 Logger::AssertAddress calls closing coverage gaps across managers (MemoryMgr had 0; also UIMgr, ItemMgr, MapMgr, AgentMgr, ChatMgr, StoCMgr).
  • SkillbarMgr: assert the TemplatesHelpers scans unconditionally (outside the if-guard) so a broken scan is logged instead of staying silently null.
  • UIMgr: fix DestroyUIComponent FrApi.cpp assertion path (\Code\Engine\Frame), a pre-existing silent-null scan surfaced by the new logging.

After a GW client update a broken pattern scan resolves to null and the
feature dies quietly with no log. This makes such failures visible:

- GWCA.cpp: a [SCAN-HEALTH] summary after module init that re-emits every
  NULL scan / FAILED hook from the central registry into Py4GW_injection_log.txt.
- +31 Logger::AssertAddress calls closing coverage gaps across managers
  (MemoryMgr had 0; also UIMgr, ItemMgr, MapMgr, AgentMgr, ChatMgr, StoCMgr).
- SkillbarMgr: assert the TemplatesHelpers scans unconditionally (outside the
  if-guard) so a broken scan is logged instead of staying silently null.
- UIMgr: fix DestroyUIComponent FrApi.cpp assertion path (\Code\Engine\Frame),
  a pre-existing silent-null scan surfaced by the new logging.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant