Fix TakeBlessing bug and add multibox feature to MoveAndInteractWithGadget#1021
Open
sloppynacho wants to merge 16 commits into
Open
Fix TakeBlessing bug and add multibox feature to MoveAndInteractWithGadget#1021sloppynacho wants to merge 16 commits into
sloppynacho wants to merge 16 commits into
Conversation
…dow collapsed An indentation regression left the "Follow Publish" section (thresholds, unstuck knobs, dirty_runtime_cfg check) outside the `if ImGui.Begin(...)` block. When the Follow Formations window was collapsed, Begin returned False, skipping `dirty_runtime_cfg = False`, but the dedented `if dirty_runtime_cfg:` still ran — raising UnboundLocalError every frame. Re-indent the block back inside Begin and restore the "Show Flagging Window" checkbox as a sibling of the dirty check (it was accidentally nested under it, only rendering on frames where a setting changed)
Concurrent multibox writes to the shared WidgetManager.ini tore the file (truncate-in-place save); reading it back logged a multi-line configparser error that tripped GW's TextParser assert and crashed the client. Started with b665952/192a53be (apoguita, 2026-05-18), which broadcast widget enable/disable to every box on BottingTree lifecycle events. save() now writes a temp file + os.replace() (atomic on NTFS).
Fixed the rotten drop item scanner in C++. Right now with the rotten scanner the widget will only dropping one item; if you apply the fix to the scanner it will drop the appropriate amount.
Introduce a per-gadget INTERACT_AGENT whiteboard lock and multibox flow to serialize gadget interactions across in-group same-map accounts. WhiteboardLocks: add INTERACT_LOCK_* constants and helper functions (post/get/clear/is_blocked) with a long default lease to cover move+interact+loot+hold. enums: add SharedCommandType.InteractGadgetWithLock. ApoBottingLib.helpers: add _broadcast_gadget_interact_with_lock to select same-map group recipients and send InteractGadgetWithLock with an adaptive timeout. wrappers: switch multibox gadget interaction to use the new broadcast helper. Widgets/System/Messaging: import lock helpers, add InteractGadgetWithLock handler implementing the lock-then-interact lifecycle (contention loop, follow-path, interact, loot, hold, and cleanup), include the new command in suspended commands and message dispatching. Overall this prevents double-interacts by serializing turns and provides timeouts and safe cleanup on failures.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.