Skip to content

fix: install headers and library (Aaron's version)#55

Merged
amarburg merged 3 commits into
mainfrom
fix/install_headers
May 21, 2026
Merged

fix: install headers and library (Aaron's version)#55
amarburg merged 3 commits into
mainfrom
fix/install_headers

Conversation

@amarburg

@amarburg amarburg commented May 6, 2026

Copy link
Copy Markdown
Collaborator

Alternative version of #52

@andresmanelli Since I'm not working with this library in a non-ROS2 context regularly, I'm not entirely sure on best practices for installing binaries. I've modified your suggested PR slightly to use CMAKE defaults for both headers and libraries.

I'm sure there are more sophisticated ways to handle it, but make install correctly installs everything in /usr/local/... Curious if this works for your use case.

andresmanelli and others added 3 commits May 6, 2026 12:58
Signed-off-by: Andrés MANELLI <amanelli@forssea-robotics.fr>
Signed-off-by: Andrés MANELLI <amanelli@forssea-robotics.fr>
@amarburg amarburg changed the title Fix/install headers fix: install headers and library (Aaron's version) May 6, 2026
@amarburg amarburg self-assigned this May 6, 2026
@andresmanelli

andresmanelli commented May 7, 2026

Copy link
Copy Markdown
Contributor

Hello @amarburg, if I may, I'd rather see explicitly what and where is something installed, especially since the original PR was not that verbose.

That being said, as the final outcome is the same, it's your call to choose one or the other.

So to answer your question, yes this also works for me :)

@andresmanelli

Copy link
Copy Markdown
Contributor

Hello @amarburg, I was wondering if this PR or #52 will be merged. Let me know if there is something missing, thanks!

@amarburg

amarburg commented May 21, 2026

Copy link
Copy Markdown
Collaborator Author

Ah, sorry, this fell off my plate. I'm going to merge this version as it uses CMake's internal defaults and should be more platform independent.

Thanks for the prompt!

@amarburg amarburg merged commit 435e141 into main May 21, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants