Added /road endpoint for vegagerdin#483
Open
olafur164 wants to merge 5 commits into
Open
Conversation
olafur164
requested review from
MiniGod,
benediktvaldez,
koddsson and
kristjanmik
as code owners
MiniGod
requested changes
Feb 24, 2019
Member
|
Do you know if we can get any info about the segments? Location or something? |
Author
|
@MiniGod Added all the regions :) |
Author
|
@MiniGod any update on when / if this will be merged? :D |
MiniGod
requested changes
Mar 29, 2019
MiniGod
left a comment
MiniGod
left a comment
Member
There was a problem hiding this comment.
Sorry for the late reply. Got some comments about coding style mostly to make this easier to maintain in the future
| @@ -0,0 +1,123 @@ | |||
| /* eslint-disable */ | |||
Member
There was a problem hiding this comment.
Please remove this and follow the eslint rules
| resolve(segments) | ||
| }) | ||
| }) | ||
| const parseFeed = function (callback, data, regionUrl) { |
Member
There was a problem hiding this comment.
This function is almost the same in the index.js file. Please try to re-use functions between the files.
| /* eslint-disable no-plusplus */ | ||
| /* eslint-disable no-prototype-builtins */ | ||
| /* eslint-disable prefer-destructuring */ | ||
| /* eslint-disable no-unneeded-ternary */ |
Member
There was a problem hiding this comment.
Please remove these and follow the eslint rules
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a new endpoint for road conditions in Iceland.
Source: Vegagerdin
Vegagerdin xml
Also has endpoints separating each region in Iceland.
South, North, West, East and more.
Checklist