Added docs for 8 endpoints and fixed 3 of them#468
Open
sse87 wants to merge 19 commits into
Open
Conversation
sse87
requested review from
MiniGod,
benediktvaldez,
koddsson and
kristjanmik
as code owners
MiniGod
requested changes
Sep 24, 2018
MiniGod
left a comment
MiniGod
left a comment
Member
There was a problem hiding this comment.
Thanks a lot! This is a lot of really nice improvements! <3
MiniGod
approved these changes
Sep 25, 2018
MiniGod
reviewed
Sep 25, 2018
MiniGod
reviewed
Sep 25, 2018
sse87
changed the title
Contributor
Author
|
I'm done adding new stuff to this PR, just fixes if you guys see anything. 😉 |
Contributor
Author
|
So any change of more reviews? I'm still here for comments. |
MiniGod
approved these changes
Feb 22, 2019
MiniGod
left a comment
MiniGod
left a comment
Member
There was a problem hiding this comment.
Only one comment, but doesn't really matter.
Contributor
Author
|
Tests fails because cached test data (mock-data.json) has mismatch or invalid information. All tests passes after I removed all island.is records from the file or total of 18 items. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New documentation for following endpoints:
/calendar/carparks/cinema/declension/golf/isbolti/isnic/namesFixed following endpoints:
/cinemaSource html changed and theater page removed/declensionSource html attribute changed/names$(this)not working in an arrow function`Improved following endpoints:
/cinemaAdded theater metadata/carparksAdded opening hours/namesAdded more options like get all names or get all declined namesMake docs for other endpoints more consistant.