Skip to content

ci: Approve pnpm build scripts for docs build#842

Merged
vdusek merged 3 commits into
masterfrom
ci/approve-pnpm-builds-docs
Jun 3, 2026
Merged

ci: Approve pnpm build scripts for docs build#842
vdusek merged 3 commits into
masterfrom
ci/approve-pnpm-builds-docs

Conversation

@vdusek
Copy link
Copy Markdown
Contributor

@vdusek vdusek commented Jun 2, 2026

The recent bump to pnpm v11 (#841) turned ignored package build scripts into a hard error, breaking the docs check:

[ERR_PNPM_IGNORED_BUILDS] Ignored build scripts: @apify/ui-icons, @swc/core, core-js, unrs-resolver

This explicitly approves those packages' build scripts via an allowBuilds section in website/pnpm-workspace.yaml (pnpm 11's mechanism for opting dependencies into running install scripts).

Verified locally that pnpm install and uv run poe build-docs both succeed.

@vdusek vdusek added adhoc Ad-hoc unplanned task added during the sprint. t-tooling Issues with this label are in the ownership of the tooling team. labels Jun 2, 2026
@vdusek vdusek self-assigned this Jun 2, 2026
@github-actions github-actions Bot added this to the 142nd sprint - Tooling team milestone Jun 2, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 2, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.72%. Comparing base (beab127) to head (b9e707a).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master     #842       +/-   ##
===========================================
+ Coverage   83.52%   94.72%   +11.19%     
===========================================
  Files          48       48               
  Lines        5045     5045               
===========================================
+ Hits         4214     4779      +565     
+ Misses        831      266      -565     
Flag Coverage Δ
integration 92.84% <ø> (?)
unit 83.52% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@vdusek vdusek requested a review from B4nan June 3, 2026 07:20
@vdusek
Copy link
Copy Markdown
Contributor Author

vdusek commented Jun 3, 2026

@B4nan, could you please check it? If this is the right way, I'll do it in the SDK & Crawlee as well.

Copy link
Copy Markdown
Member

@B4nan B4nan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets drop core-js, otherwise it looks good.

Comment thread website/pnpm-workspace.yaml Outdated
@vdusek vdusek merged commit d2ab2ae into master Jun 3, 2026
27 checks passed
@vdusek vdusek deleted the ci/approve-pnpm-builds-docs branch June 3, 2026 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

adhoc Ad-hoc unplanned task added during the sprint. t-tooling Issues with this label are in the ownership of the tooling team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants