Fix/puppeteer browser install windows#812
Open
l2ysho wants to merge 2 commits into
Open
Conversation
l2ysho
requested review from
B4nan,
DaveHanns,
vdusek and
vladfrangu
and removed request for
vdusek and
vladfrangu
github-actions
Bot
added
t-tooling
vladfrangu
reviewed
Jun 18, 2026
vladfrangu
left a comment
vladfrangu
left a comment
Member
There was a problem hiding this comment.
Also please run a /simplify or smth, the amount of comments to code changes are insaaane
Comment on lines
+11
to
+18
| # Pinned to windows-2022 rather than windows-latest: the js-langchain | ||
| # template depends on the native hnswlib-node addon, which is compiled with | ||
| # node-gyp at install time. The windows-latest image ships Visual Studio 18 | ||
| # (2026), which the bundled node-gyp cannot detect ("find VS unknown version"), | ||
| # so the native build fails. windows-2022 ships VS 2022, which node-gyp | ||
| # supports. See https://github.com/apify/actor-templates/issues/813 for | ||
| # removing the native dependency. | ||
| os: [ubuntu-24.04, windows-2022] |
Member
There was a problem hiding this comment.
I'm surprised thats the issue... I would rather figure out how to fix node-gyp, not downgrade windows to 2022
…emplate tests
The `Test Node.js templates (windows-latest, 24)` job has been failing daily.
Puppeteer templates download their pinned Chrome via a postinstall hook into the
shared user-level cache (~/.cache/puppeteer), reused across template runs. On
Windows a partially-written entry from one puppeteer template poisons the next
template's install ("browser folder exists but the executable is missing"), so
`npm install` exits 1 and the test fails.
Pin Puppeteer's cache to one explicit PUPPETEER_CACHE_DIR shared by every step:
- Workflow: pre-install the pinned browsers (chrome + chrome-headless-shell)
into PUPPETEER_CACHE_DIR before the tests, mirroring the Playwright step, so
templates start from a complete cache.
- Harness: honor an externally provided PUPPETEER_CACHE_DIR (falling back to a
temp dir locally) so `npm install` and `apify run` agree on one location, and
retry `npm install` for puppeteer templates, clearing the cache between
attempts so a corrupted entry can't wedge every retry.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
js-langchain's native hnswlib-node addon fails to build on the windows-latest image: it now ships Visual Studio 2026, which the bundled node-gyp can't detect, so `npm install` exits 1. windows-2022 ships VS 2022, which node-gyp supports. Removing the native dependency is tracked in #813. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
l2ysho
force-pushed
the
fix/puppeteer-browser-install-windows
branch
from
da15cc0 to
e1bc3f4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #806 pipeline
fixes #808 pipeline
follow up #813 to fix win properly