Put Afterquery logic into a single object.#4
Open
AlanDeSmet wants to merge 11 commits into
Open
Conversation
Allows running off of file:/// URLs, and should work in all other cases.
They might be useful outside of Afterquery. Also makes clearer who might side-effect.
To make it more distinct from upstream.
localStorage was disabled because it broken file:/// usage. Added a quick and dirty check to not use it for URLs lacking a //. Also removed some obsolete debugging messages.
agg_funcs now get a reference to the AfterqueryObj.
Untested.
this->that
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I wanted to be able to put multiple visualizations on a single page without iframes, as well as eventually doing a few other perhaps overly clever things like caching parsed data. To this end, I overhauled Afterquery to put all of its logic into a single object. I'm hoping it's drop-in compatible; the new object is AfterqueryObj, and the afterquery.render interface is implemented in terms of it.
This may not work for you given your own design and goals for Afterquery, but I wanted to offer it up in case it was useful.