test: unit tests for LandingPageComponent#5234
Open
Ma77Ball wants to merge 1 commit into
Open
Conversation
Contributor
Author
|
/request-review @aicam |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this PR?
landing-page.component.spec.tscovering creation, the constructor'suserChanged()subscription (login/logout transitions updateisLoginandcurrentUid),ngOnInitcalling bothgetWorkflowCountandloadTops, count population fromHubService.getCount, the three top-loved buckets populated byloadTops, theloadTopserror path logging viaconsole.error,getTopLovedEntriesenriching items viaSearchService.extendSearchResultsWithHubActivityInfo(items, true, ["access"])per action and returning a map keyed by action, andnavigateToSearchrouting for"workflow","dataset", and unknown types.HubService,SearchService,WorkflowPersistService, andDatasetService; reuseStubUserServicefor a realuserChanged()subject; replaceRouter.navigatewith a vitest spy.Any related issues, documentation, or discussions?
Closes: #5225
How was this PR tested?
yarn ng test --watch=false --include='src/app/hub/component/landing-page/landing-page.component.spec.ts', 10/10 tests pass.yarn format:fix(1 file formatted, 505 unchanged).Was this PR authored or co-authored using generative AI tooling?
Co-authored with Claude Opus 4.7 in compliance with ASF