Register all transitive interfaces as services as well#120
Conversation
| paren_count += self.lines[j].count('(') - self.lines[j].count(')') | ||
| j += 1 | ||
|
|
||
| # Extract interfaces from "implements Interface1, Interface2, ..." |
There was a problem hiding this comment.
Also needs to consider interfaces implemented by base classes.
There was a problem hiding this comment.
Also needs a broader search for the base class/interface declaration (without necessarily evaluating the full Maven classpath....). Maybe some commons base classes can be added here like SlingSafeMethodsServlet, SlingAllMethodsServlet or javax.servlet.GenericServlet with their implemented interfaces.
There was a problem hiding this comment.
Maybe instead of checking the source code one can instead evaluate the generated component descriptors generated by Felix SCR plugin.
There was a problem hiding this comment.
that's probably the better option, I guess this should be done anyway to compare old vs new
There was a problem hiding this comment.
I have some notes about comparing the new and old descriptors in https://github.com/apache/sling-whiteboard/blob/master/skills/update-sling-parent-pom/references/osgi-annotations.md#validation , they might be useful here.
Maybe we can convince @jsedding to release that tool to Maven Central :-)
There was a problem hiding this comment.
kwin
force-pushed
the
bugfix/service-values-in-scr-skill
branch
from
b918f46 to
f162d69
Compare
4 participants
No description provided.