Skip to content

Resolving consumer beans from CGLIB proxy classes created by @Configuration#596

Open
yx-Yaoxaing wants to merge 1 commit into
apache:masterfrom
yx-Yaoxaing:master
Open

Resolving consumer beans from CGLIB proxy classes created by @Configuration#596
yx-Yaoxaing wants to merge 1 commit into
apache:masterfrom
yx-Yaoxaing:master

Conversation

@yx-Yaoxaing

Copy link
Copy Markdown

What is the purpose of the change

Originally, when annotating a class with @configuration, it couldn't be resolved as a RocketMQ consumer listener class. I changed the way annotations are parsed, allowing classes marked with @configuration to be correctly identified as RocketMQ consumer listener classes. This is because, in our practice at the company, many people also prefer using @configuration.

Brief changelog

In the postProcessAfterInitialization() method of the RocketMQMessageListenerBeanPostProcessor message listener post-processor, I changed the annotation processing approach to:
RocketMQMessageListener ann = (RocketMQMessageListener) AnnotationUtils.findAnnotation(targetClass, RocketMQMessageListener.class);
This modification allows both @configuration and @service annotated classes to function as consumer listeners.

Verifying this change

In production and actively deployed.
RocketMQMessageListener ann = AnnotationUtils.findAnnotation(targetClass, RocketMQMessageListener.class);

@RockteMQ-AI RockteMQ-AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review: Approved ✅

PR: #596 — Resolving consumer beans from CGLIB proxy classes created by @configuration
Type: Bug fix (1 file, +1/-1)

Assessment

Uses ClassUtils.getUserClass() to unwrap CGLIB proxy classes, allowing @Configuration annotated classes to be correctly identified as RocketMQ consumer listeners.

Verdict

✅ Minimal, correct fix for Spring proxy class handling.


🤖 Automated review by oss-sentinel-ai

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants