change MessageConverter.fromMessage()'s parameter Type from String to byte[]

[gepengjun]

What is the purpose of the change

i think byte[] is more suitable for the most MessageConverter than String, byte[] is suitable the current MessageConverters such as
ByteArrayMessageConverter, StringMessageConverter, MappingJackson2MessageConverter, MappingFastJsonMessageConverter,
and it is yet suitable for ProtobufMessageConverter;

[gepengjun]

i want to serialize and deserialize the message with ProtobufMessageConverter so i define RocketMQMessageConverter like this
@bean
public RocketMQMessageConverter rocketMQMessageConverter(ProtobufMessageConverter protobufMessageConverter){
RocketMQMessageConverter rocketMQMessageConverter = new RocketMQMessageConverter();
CompositeMessageConverter messageConverter = (CompositeMessageConverter)rocketMQMessageConverter.getMessageConverter();
messageConverter.getConverters().add(0, protobufMessageConverter);
return rocketMQMessageConverter;
}
but an exception occured when consumer the message:
Caused by: java.lang.ClassCastException: class java.lang.String cannot be cast to class [B (java.lang.String and [B are in module java.base of loader 'bootstrap')
at org.springframework.messaging.converter.ProtobufMessageConverter.convertFromInternal(ProtobufMessageConverter.java:147) ~[spring-messaging-5.2.8.RELEASE.jar:5.2.8.RELEASE]

[RockteMQ-AI]

Review: Approved ✅

PR: #534 — Change MessageConverter.fromMessage() parameter type from String to byte[]
Type: Enhancement (1 file, +2/-2)

Assessment

Changes the parameter type to byte[] which is more suitable for all built-in MessageConverter implementations (ByteArray, String, MappingJackson2, MappingFastJson).

Verdict

✅ Correct API improvement. byte[] is the natural message payload type.

---

🤖 Automated review by oss-sentinel-ai