Skip to content

[issue #221] fix notify retry topic subscribe duplicated.#235

Open
echooymxq wants to merge 1 commit into
apache:mainfrom
echooymxq:main
Open

[issue #221] fix notify retry topic subscribe duplicated.#235
echooymxq wants to merge 1 commit into
apache:mainfrom
echooymxq:main

Conversation

@echooymxq

@echooymxq echooymxq commented Jan 12, 2024

Copy link
Copy Markdown

fix #221

@DongyuanPan DongyuanPan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that this should not be changed, and the issue mentioned is not the problem caused here

@ChangingFond

Copy link
Copy Markdown
Contributor

It seems that this should not be changed, and the issue mentioned is not the problem caused here

+1

@RockteMQ-AI RockteMQ-AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review by github-manager-bot

Summary

One-line fix for issue #221: corrects the retry topic filter in NotifyManager.refresh() to use getEventNotifyRetryTopic() instead of getClientRetryTopic(), preventing duplicate subscription of the event notify retry topic.

Findings

  • [Info] NotifyManager.java:128 — The fix correctly changes the topic comparison from getClientRetryTopic() to getEventNotifyRetryTopic(). This ensures that the event notify retry topic is properly excluded from the subscription refresh, preventing duplicate subscriptions.

  • [Warning] The PR description is minimal (fix #221). Consider adding a brief explanation of the root cause (e.g., getClientRetryTopic() returns a different topic name than the event notify retry topic, causing the filter to miss it and subscribe to the retry topic again`).

Verdict

Correct one-line fix. Low risk. LGTM.


Automated review by github-manager-bot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

一直写java.lang.NullPointerException: null日志,每天产生60G日志

4 participants