[issue #221] fix notify retry topic subscribe duplicated.#235
Conversation
DongyuanPan
left a comment
There was a problem hiding this comment.
It seems that this should not be changed, and the issue mentioned is not the problem caused here
+1 |
RockteMQ-AI
left a comment
There was a problem hiding this comment.
Review by github-manager-bot
Summary
One-line fix for issue #221: corrects the retry topic filter in NotifyManager.refresh() to use getEventNotifyRetryTopic() instead of getClientRetryTopic(), preventing duplicate subscription of the event notify retry topic.
Findings
-
[Info]
NotifyManager.java:128— The fix correctly changes the topic comparison fromgetClientRetryTopic()togetEventNotifyRetryTopic(). This ensures that the event notify retry topic is properly excluded from the subscription refresh, preventing duplicate subscriptions. -
[Warning] The PR description is minimal (
fix #221). Consider adding a brief explanation of the root cause (e.g.,getClientRetryTopic()returns a different topic name than the event notify retry topic, causing the filter to miss it and subscribe to the retry topic again`).
Verdict
Correct one-line fix. Low risk. LGTM.
Automated review by github-manager-bot
fix #221