Skip to content

RANGER-5602: Local build failure due to unit test failure in TestPolicyACLs#948

Open
ChinmayHegde24 wants to merge 1 commit into
apache:masterfrom
ChinmayHegde24:RANGER-5602
Open

RANGER-5602: Local build failure due to unit test failure in TestPolicyACLs#948
ChinmayHegde24 wants to merge 1 commit into
apache:masterfrom
ChinmayHegde24:RANGER-5602

Conversation

@ChinmayHegde24
Copy link
Copy Markdown
Contributor

local maven build i.e mvn clean install
is failing with
TestPolicyACLs.testResourceACLs_dataMask:85->runTestsFromResourceFiles:107->runTests:122->lambda$runTests$0:127 » ConcurrentModification

RangerPolicyEngine policyEngine = new RangerPolicyEngineImpl(testCase.servicePolicies, pluginContext, null);

testCase.tests.parallelStream().filter(Objects::nonNull).forEach(oneTest -> {
testCase.tests.stream().filter(Objects::nonNull).forEach(oneTest -> {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't change it from parallelStream to stream. I’ve been investigating this and the parallel execution was an intentional change made as part of RANGER-5115.

We need more analysis to determine the correct fix for this test failure. The test only started failing a couple of hours ago in my local env, so I haven’t finished the root cause analysis yet.

If this is blocking, we can temporarily disable the test, but I recommend not modifying the test logic.

@ChinmayHegde24 If it’s urgent, please disable the test for now. We’ll analyze the failure and push a proper fix

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vyommani Sure , that will cause only issues in local build, in CI it's fine anyway so it'll not block there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants