Skip to content

[fix][test] Split and fix flaky SASL authentication first-stage auth cache tests #25949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
oneby-wang wants to merge 3 commits into
base: master
Choose a base branch
from
+32 −26
Open

[fix][test] Split and fix flaky SASL authentication first-stage auth cache tests #25949

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
07879a2
[fix][test] Split SASL first-stage auth cache tests
oneby-wang Jun 6, 2026
6c6057a
Delete old test
oneby-wang Jun 6, 2026
986713e
Address pr comment
oneby-wang Jun 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
58 changes: 32 additions & 26 deletions ...auth-sasl/src/test/java/org/apache/pulsar/broker/authentication/SaslAuthenticateTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,13 +61,12 @@
import org.apache.pulsar.common.api.AuthData;
import org.apache.pulsar.common.sasl.SaslConstants;
import org.apache.pulsar.common.util.ObjectMapperFactory;
import org.testng.Assert;
import org.awaitility.Awaitility;
import org.testng.annotations.AfterClass;
import org.testng.annotations.AfterMethod;
import org.testng.annotations.BeforeClass;
import org.testng.annotations.BeforeMethod;
import org.testng.annotations.Test;
import org.testng.collections.CollectionUtils;

@CustomLog
public class SaslAuthenticateTest extends ProducerConsumerBase {
Expand Down Expand Up @@ -220,7 +219,7 @@ protected void setup() throws Exception {
@Override
protected void cleanup() throws Exception {
FileUtils.deleteQuietly(secretKeyFile);
Assert.assertFalse(secretKeyFile.exists());
assertFalse(secretKeyFile.exists());
super.internalCleanup();
}

Expand Down Expand Up @@ -310,49 +309,56 @@ public void testSaslServerAndClientAuth() throws Exception {

@Test
@SuppressWarnings("unchecked")
public void testSaslOnlyAuthFirstStage() throws Exception {
public void testSaslOnlyAuthFirstStageKeepsInflightContextsBeforeExpiry() throws Exception {
@Cleanup
AuthenticationProviderSasl saslServer = new AuthenticationProviderSasl();
// The cache expiration time is set to 500ms. Residual auth info should be cleaned up
conf.setInflightSaslContextExpiryMs(500);
conf.setInflightSaslContextExpiryMs(Integer.MAX_VALUE);
saslServer.initialize(AuthenticationProvider.Context.builder().config(conf).build());

HttpServletRequest servletRequest = mock(HttpServletRequest.class);
doReturn("Init").when(servletRequest).getHeader("State");
// 10 clients only do one-stage verification, resulting in 10 auth info remaining in memory
doReturn(SaslConstants.SASL_STATE_CLIENT_INIT).when(servletRequest).getHeader(SaslConstants.SASL_HEADER_STATE);
for (int i = 0; i < 10; i++) {
AuthenticationDataProvider dataProvider = authSasl.getAuthData("localhost");
AuthenticationDataProvider dataProvider = authSasl.getAuthData(localHostname);
AuthData initData1 = dataProvider.authenticate(AuthData.INIT_AUTH_DATA);
doReturn(Base64.getEncoder().encodeToString(initData1.getBytes())).when(
servletRequest).getHeader("SASL-Token");
doReturn(String.valueOf(i)).when(servletRequest).getHeader("SASL-Server-ID");
servletRequest).getHeader(SaslConstants.SASL_AUTH_TOKEN);
doReturn(String.valueOf(i)).when(servletRequest).getHeader(SaslConstants.SASL_STATE_SERVER);
saslServer.authenticateHttpRequest(servletRequest, mock(HttpServletResponse.class));
}

Field field = AuthenticationProviderSasl.class.getDeclaredField("authStates");
field.setAccessible(true);
Cache<Long, AuthenticationState> cache = (Cache<Long, AuthenticationState>) field.get(saslServer);
assertEquals(cache.asMap().size(), 10);
// Add more auth info into memory
}

@Test
@SuppressWarnings("unchecked")
public void testSaslOnlyAuthFirstStageExpiresResidualContexts() throws Exception {
@Cleanup
AuthenticationProviderSasl saslServer = new AuthenticationProviderSasl();
conf.setInflightSaslContextExpiryMs(50);
saslServer.initialize(AuthenticationProvider.Context.builder().config(conf).build());

HttpServletRequest servletRequest = mock(HttpServletRequest.class);
doReturn(SaslConstants.SASL_STATE_CLIENT_INIT).when(servletRequest).getHeader(SaslConstants.SASL_HEADER_STATE);
for (int i = 0; i < 10; i++) {
AuthenticationDataProvider dataProvider = authSasl.getAuthData("localhost");
AuthenticationDataProvider dataProvider = authSasl.getAuthData(localHostname);
AuthData initData1 = dataProvider.authenticate(AuthData.INIT_AUTH_DATA);
doReturn(Base64.getEncoder().encodeToString(initData1.getBytes())).when(
servletRequest).getHeader("SASL-Token");
doReturn(String.valueOf(10 + i)).when(servletRequest).getHeader("SASL-Server-ID");
servletRequest).getHeader(SaslConstants.SASL_AUTH_TOKEN);
doReturn(String.valueOf(i)).when(servletRequest).getHeader(SaslConstants.SASL_STATE_SERVER);
saslServer.authenticateHttpRequest(servletRequest, mock(HttpServletResponse.class));
}
long start = System.currentTimeMillis();
while (true) {
if (System.currentTimeMillis() - start > 5000) {
fail();
}
cache = (Cache<Long, AuthenticationState>) field.get(saslServer);
// Residual auth info should be cleaned up
if (CollectionUtils.hasElements(cache.asMap())) {
break;

Field field = AuthenticationProviderSasl.class.getDeclaredField("authStates");
field.setAccessible(true);
Cache<Long, AuthenticationState> cache = (Cache<Long, AuthenticationState>) field.get(saslServer);
Awaitility.await().atMost(5, TimeUnit.SECONDS).pollDelay(100, TimeUnit.MILLISECONDS).untilAsserted(() -> {
for (int i = 0; i < 10; i++) {
assertNull(cache.getIfPresent(((long) i)));
}
Thread.sleep(5);
}
});
}

@Test
Expand Down
Loading