[cleanup][broker] Standardize java.time.Clock usage in broker service#25935
Open
Praveenkumar76 wants to merge 2 commits into
Open
[cleanup][broker] Standardize java.time.Clock usage in broker service#25935Praveenkumar76 wants to merge 2 commits into
Praveenkumar76 wants to merge 2 commits into
Conversation
1277267 to
3a439ac
Compare
ca1957f to
3a439ac
Compare
3a439ac to
a79fbc5
Compare
d3a9bbc to
53f8f24
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes apache#25660
Motivation
The usage of
java.time.Clockis currently inconsistent across the broker module, with many classes directly relying onSystem.currentTimeMillis()for timestamp generation.Standardizing timestamp handling through the centralized
PulsarServiceclock improves consistency across the codebase and makes time-dependent behavior easier to control during testing. This reduces test flakiness by enabling deterministic time mocking in unit and integration tests.Because there are hundreds of occurrences of
System.currentTimeMillis()across the repository, this PR intentionally scopes the change to a tightly focused set of classes. It specifically targets classes where theClockdependency can be cleanly injected via the constructor, ensuring a clear separation of concerns and keeping the review safe and manageable.Modifications
Replaced direct usages of System.currentTimeMillis() with this.clock.millis() by utilizing field injection for the Clock dependency in the following broker module classes:
MessageDeduplication.javaSchemaRegistryStats.javaPulsarStats.javaAdditional changes:
System.nanoTime()usages unchanged, as they are used for monotonic latency measurements rather than wall-clock timestamps.Verifying this change
This change can be verified as follows:
System.nanoTime().Does this pull request potentially affect one of the following parts: