[fix][client] Log the exception in ControlledClusterFailover.close#25925
Open
PavelZeger wants to merge 1 commit into
Open
[fix][client] Log the exception in ControlledClusterFailover.close#25925PavelZeger wants to merge 1 commit into
PavelZeger wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #25898
Motivation
When
httpClient.close()fails inControlledClusterFailover.close(), the caughtIOExceptionwas discarded - only a static"Failed to close http client."line was logged. An operator could not tell whether the failure was aSocketTimeoutException, a connection reset, or an internal error, each of which calls for a different remedy. Since thisclose()runs when a client transitions away from a cluster, it is often the only signal that the failover completed cleanly, so losing the cause hurtsdiagnosability.
Modifications
Attach the caught
IOExceptionto the log event via slog's.exception(e), matching the logging pattern already used elsewhere in this class.Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts: