Skip to content

[fix][broker] support config receve buffer #20161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lordcheng10 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[fix][broker] support config receve buffer #20161

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3216647
support config receve buffer
lordcheng10 Apr 21, 2023
db74b66
support receive buffer config
lordcheng10 Apr 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions pulsar-broker-common/src/main/java/org/apache/pulsar/broker/ServiceConfiguration.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -844,6 +844,26 @@ The delayed message index time step(in seconds) in per bucket snapshot segment,
+ "it can be enabled to reduce the memory consumption caused by pendingAcks.")
private boolean autoShrinkForConsumerPendingAcksMap = false;

@FieldContext(
category = CATEGORY_SERVER,
dynamic = true,
doc = "The minimum receive buffer size for AdaptiveRecvByteBufAllocator"

@Jason918 Jason918 Apr 21, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add more doc to guiding user to tune the value of this config?

)
private int minReceiveByteBuf = 1024;

@Jason918 Jason918 Apr 21, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make the config name more descriptive. Maybe like minReceiveSizeForNettyByteBufAllocator ?


@FieldContext(
category = CATEGORY_SERVER,
dynamic = true,
doc = "The init receive buffer size for AdaptiveRecvByteBufAllocator"
)
private int initReceiveByteBuf = 16 * 1024;

@FieldContext(
category = CATEGORY_SERVER,
dynamic = true,
doc = "The max receive buffer size for AdaptiveRecvByteBufAllocator"
)
private int maxReceiveByteBuf = 1 * 1024 * 1024;
@FieldContext(
category = CATEGORY_SERVER,
dynamic = true,
Expand Down
11 changes: 9 additions & 2 deletions pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -442,8 +442,11 @@ private void startProtocolHandler(String protocol,
bootstrap.option(ChannelOption.SO_REUSEADDR, true);
bootstrap.childOption(ChannelOption.ALLOCATOR, PulsarByteBufAllocator.DEFAULT);
bootstrap.childOption(ChannelOption.TCP_NODELAY, true);
int minReceiveByteBuf = pulsar().getConfiguration().getMinReceiveByteBuf();
int initReceiveByteBuf = pulsar().getConfiguration().getInitReceiveByteBuf();
int maxReceiveByteBuf = pulsar().getConfiguration().getMaxReceiveByteBuf();
bootstrap.childOption(ChannelOption.RCVBUF_ALLOCATOR,
new AdaptiveRecvByteBufAllocator(1024, 16 * 1024, 1 * 1024 * 1024));
new AdaptiveRecvByteBufAllocator(minReceiveByteBuf, initReceiveByteBuf, maxReceiveByteBuf));
EventLoopUtil.enableTriggeredMode(bootstrap);
DefaultThreadFactory defaultThreadFactory =
new ExecutorProvider.ExtendedThreadFactory("pulsar-ph-" + protocol);
Expand All @@ -470,8 +473,12 @@ private ServerBootstrap defaultServerBootstrap() {
bootstrap.childOption(ChannelOption.ALLOCATOR, PulsarByteBufAllocator.DEFAULT);
bootstrap.group(acceptorGroup, workerGroup);
bootstrap.childOption(ChannelOption.TCP_NODELAY, true);
int minReceiveByteBuf = pulsar().getConfiguration().getMinReceiveByteBuf();
int initReceiveByteBuf = pulsar().getConfiguration().getInitReceiveByteBuf();
int maxReceiveByteBuf = pulsar().getConfiguration().getMaxReceiveByteBuf();
bootstrap.childOption(ChannelOption.RCVBUF_ALLOCATOR,
new AdaptiveRecvByteBufAllocator(1024, 16 * 1024, 1 * 1024 * 1024));
new AdaptiveRecvByteBufAllocator(minReceiveByteBuf,
initReceiveByteBuf, maxReceiveByteBuf));
bootstrap.channel(EventLoopUtil.getServerSocketChannelClass(workerGroup));
EventLoopUtil.enableTriggeredMode(bootstrap);
return bootstrap;
Expand Down