[fix][broker]fix missing return when internalGetReplicatedSubscriptionStatus#19054
Merged
Conversation
nodece
approved these changes
Dec 26, 2022
Contributor
Author
|
/pulsarbot rerun-failure-checks |
Codecov Report
@@ Coverage Diff @@
## master #19054 +/- ##
============================================
- Coverage 47.20% 46.98% -0.22%
+ Complexity 10645 10594 -51
============================================
Files 709 709
Lines 69421 69422 +1
Branches 7449 7449
============================================
- Hits 32769 32620 -149
- Misses 32984 33120 +136
- Partials 3668 3682 +14
Flags with carried forward coverage won't be shown. Click here to find out more.
|
liangyepianzhou
left a comment
liangyepianzhou
left a comment
Contributor
There was a problem hiding this comment.
Suggested changes:
if (exception != null) {
...
} else {
...
}
return null;
poorbarcode
approved these changes
Dec 27, 2022
AnonHxy
approved these changes
Dec 27, 2022
congbobo184
approved these changes
Dec 27, 2022
tisonkun
pushed a commit
to tisonkun/pulsar
that referenced
this pull request
Dec 27, 2022
…nStatus (apache#19054) ### Motivation Fix missing `return null` if throw any exception when `internalGetReplicatedSubscriptionStatus` ### Modifications Add `return null` when handing exception in `internalGetReplicatedSubscriptionStatus`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Fix missing
return nullif throw any exception wheninternalGetReplicatedSubscriptionStatusModifications
Add
return nullwhen handing exception ininternalGetReplicatedSubscriptionStatus.Verifying this change
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: HQebupt#7