add tests to see if old format ByteStrings serialized using JDK can be deserialized#2928
Draft
pjfanning wants to merge 5 commits into
Draft
add tests to see if old format ByteStrings serialized using JDK can be deserialized#2928pjfanning wants to merge 5 commits into
pjfanning wants to merge 5 commits into
Conversation
Member
Author
|
I'll look again at this. It does seem like a good idea to put a serialVersionId on the problem class but I will need to get the right value from the 1.6.0 release and to update the test bin files. |
Member
Author
|
Actually after #2929, Pekko 2 won't be able to deserialize Pekko 1.x ByteString1C instances with or without this change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
an experiment but could be useful as a regression test