HDDS-15197. Remove unnecessary BelongsToLayoutVersion annotations.#10205
Open
errose28 wants to merge 1 commit intoapache:HDDS-14496-zdufrom
Open
HDDS-15197. Remove unnecessary BelongsToLayoutVersion annotations.#10205errose28 wants to merge 1 commit intoapache:HDDS-14496-zdufrom
errose28 wants to merge 1 commit intoapache:HDDS-14496-zdufrom
Conversation
errose28
added
the
zdu
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The
@BelongsTo[HDDS]LayoutVersionannotations are largely unused, and have minimal built in handling. To simplify the options for developers using the framework, avoid confusion, and reduce the amount items to track for ZDU, we should remove them.Currently the only usage in
DatanodeDetailsincorrectly brings server side layout features into the client dependency scope inhdds-common. In this change equivalent functionality is achieved with the existing server sideVersionedDatanodeFeaturesutility class which is used in other places to handle version specific formatting. This sets us up to remove all server side upgrade functionality fromhdds-commonin HDDS-15196.What is the link to the Apache JIRA
HDDS-15197
How was this patch tested?
Refactor and delete only, existing tests pass on my fork.