HDDS-15905. Cleanup and format templates

[dnskr]

What changes were proposed in this pull request?

1. Deleted redundant new lines in env variables template:

   • Deleted commented env variable OZONE-SITE.XML_ozone.scm.skip.bootstrap.validation
   • Added newline removal to include function call.

   Before

             env:
               
               - name: OZONE-SITE.XML_hdds.datanode.dir
                 value: /data/storage
               - name: OZONE-SITE.XML_ozone.scm.datanode.id.dir
                 value: /data/metadata
               - name: OZONE-SITE.XML_ozone.metadata.dirs
                 value: /data/metadata
               - name: OZONE-SITE.XML_ozone.scm.ratis.enable
                 value: "true"
               - name: OZONE-SITE.XML_ozone.scm.service.ids
                 value: cluster1
               - name: OZONE-SITE.XML_ozone.scm.nodes.cluster1
                 value: ozone-scm-0
                 
                 
               - name: OZONE-SITE.XML_ozone.scm.address.cluster1.ozone-scm-0
                 value: ozone-scm-0.ozone-scm-headless.default.svc.cluster.local

   After

             env:
               - name: OZONE-SITE.XML_hdds.datanode.dir
                 value: /data/storage
               - name: OZONE-SITE.XML_ozone.scm.datanode.id.dir
                 value: /data/metadata
               - name: OZONE-SITE.XML_ozone.metadata.dirs
                 value: /data/metadata
               - name: OZONE-SITE.XML_ozone.scm.ratis.enable
                 value: "true"
               - name: OZONE-SITE.XML_ozone.scm.service.ids
                 value: cluster1
               - name: OZONE-SITE.XML_ozone.scm.nodes.cluster1
                 value: ozone-scm-0
               - name: OZONE-SITE.XML_ozone.scm.address.cluster1.ozone-scm-0
                 value: ozone-scm-0.ozone-scm-headless.default.svc.cluster.local

2. Deleted unused code from _helpers.tpl.

3. Deleted redundant space emptyDir: { } -> emptyDir: {}.

4. Added missing new line at the end of template files.

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-15905

How was this patch tested?

Render the chart templates:

helm template ozone charts/ozone --set recon.enabled=true

[adoroszlai]

Thanks @dnskr for the patch.

[adoroszlai]

I'm not sure about this removal. @Tejaskriya please confirm

[dnskr]

There is no usage of "ozone.scm.decommissioned.nodes" named template in the project, see search results.