HDDS-14229. Create slim ozone-runner image#51
Conversation
adoroszlai
left a comment
adoroszlai
left a comment
There was a problem hiding this comment.
Thanks @rich7420 for the patch.
| echo "${sha256} *openjdk.tar.gz" | sha256sum -c - && \ | ||
| tar xzvf openjdk.tar.gz -C /usr/local && \ | ||
| rm -f openjdk.tar.gz | ||
| RUN dnf install -y java-21-openjdk-headless && dnf clean all |
There was a problem hiding this comment.
This no longer needs to be a separate step. Please add java-21-openjdk-headless at:
ozone-docker-runner/Dockerfile
Lines 21 to 22 in d9b35b9
| ENTRYPOINT ["/usr/local/bin/dumb-init", "--", "entrypoint.sh"] | ||
| ENTRYPOINT ["/usr/local/bin/dumb-init", "--", "entrypoint.sh"] No newline at end of file |
There was a problem hiding this comment.
nit: please don't remove newline at EOF.
|
@adoroszlai thanks for the review! |
adoroszlai
left a comment
adoroszlai
left a comment
There was a problem hiding this comment.
Thanks @rich7420 for updating the patch.
| ENV JAVA_HOME=/usr/local/jdk-21.0.2 | ||
| # compatibility with Ozone 1.4.0 and earlier compose env. | ||
| RUN mkdir -p /usr/lib/jvm && ln -s $JAVA_HOME /usr/lib/jvm/jre | ||
| ENV JAVA_HOME=/usr/lib/jvm/java-21-openjdk |
There was a problem hiding this comment.
Sorry I missed it earlier. Tried to test the image with Ozone, got:
JAVA_HOME /usr/lib/jvm/java-21-openjdk does not exist.
It should be /usr/lib/jvm/jre-21-openjdk.
|
fixed, thx for the reminder! |
|
Thanks @rich7420 for the patch. |
|
Thanks @adoroszlai ! |
|
Sorry, I just found that we'll need |
2 participants
What changes were proposed in this pull request?
Create slim ozone-runner image
What is the link to the Apache JIRA
HDDS-14229
How was this patch tested?
https://github.com/rich7420/ozone-docker-runner/actions/runs/20477564021