Fix: patcher.py registry block passes wrong key to registry.patch#103
Open
mobs75 wants to merge 1 commit into
Open
Fix: patcher.py registry block passes wrong key to registry.patch#103mobs75 wants to merge 1 commit into
mobs75 wants to merge 1 commit into
Conversation
…s 'milvus', should be 'registry')
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In
nuvolaris/patcher.py, the block guarded byif "registry" in what_to_dowas incorrectly passingwhat_to_do['milvus']toregistry.patch()instead ofwhat_to_do['registry'].Root Cause
This is a copy-paste error from the adjacent
milvusblock. The guard condition correctly checks for"registry", but the dictionary access used the wrong key.Impact
A
KeyError: 'milvus'is raised inwhisk_updatewhenever:spec.components.registry(registry is added or changed)spec.components.milvus(milvus is absent fromlast-handled-configurationor unchanged)This silently breaks any platform update that touches the registry component without simultaneously touching milvus.
Fix
One-line change: replace
what_to_do['milvus']withwhat_to_do['registry']in the registry block.Testing
Verified by code inspection that all other
what_to_doaccesses inpatcher.pycorrectly match their guard conditions. This block was the only mismatch.