boards/xtensa/esp32: Add LED support for#18831
Open
Shriyans406 wants to merge 1 commit intoapache:masterfrom
Open
boards/xtensa/esp32: Add LED support for#18831Shriyans406 wants to merge 1 commit intoapache:masterfrom
Shriyans406 wants to merge 1 commit intoapache:masterfrom
Conversation
github-actions
Bot
added
Size: S
Shriyans406
force-pushed
the
boards/esp32/heltec_leds
branch
from
69d120b to
c830627
Compare
github-actions
Bot
added
Size: M
linguini1
requested changes
May 2, 2026
Contributor
linguini1
left a comment
linguini1
left a comment
There was a problem hiding this comment.
Thanks for the contribution! Please fill out the PR template according to the contribution guide, and also run ./tools/checkpatch.sh on your changes to make sure it meets the coding style (that is why CI is failing)
Shriyans406
force-pushed
the
boards/esp32/heltec_leds
branch
2 times, most recently
from
7a04e7e to
2fbefa9
Compare
jerpelea
previously approved these changes
May 4, 2026
eren-terzioglu
approved these changes
May 4, 2026
Contributor
|
@Shriyans406 please fix these issues in your file: |
Contributor
Do you have like a photo of the LED working on your board? Or how did you verify registration? |
linguini1
reviewed
May 6, 2026
Heltec WiFi LoRa 32 board This commit adds the User LED driver support for the Heltec WiFi LoRa 32 board. It implements the lower-half driver, maps the onboard white LED to GPIO 25, and adds the necessary build system and initialization logic. Signed-off-by: Shriyans Sahoo <shriyans.s.sahoo@gmail.com>
Shriyans406
force-pushed
the
boards/esp32/heltec_leds
branch
from
2fbefa9 to
e6668ca
Compare
jerpelea
approved these changes
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Added support for the onboard User LED on the Heltec WiFi LoRa 32 board. This board-specific implementation utilizes the standard NuttX User LED framework (
/dev/userleds), mapping the white LED to GPIO 25. Cleaned up a conflicting legacyGPIO_LED1definition.Impact
Enables the
/dev/userledscharacter device on theheltec_wifi_lora32board. No impact on other boards or existing architectures.Testing
Tested by building the
heltec_wifi_lora32configuration in a Linux environment. Verified the driver registration inesp32_bringup.cand validated the coding style usingcheckpatch.sh.