Bug: Settings interpolation and strict parsing - #11776
Merged
Merged
Conversation
Problem: today in none of Maven 3 is possible to use placeholders and apply interpolation to non-String fields (ie proxy.active or proxy.port). Moreover, given Maven is "forigiving" in settings parsing, and only WARNs, it is very easy for user to miss information. This PR: * fixes interpolation for whole settings * allows users to apply "strict" settings parsing that makes Maven FAIL if settings was not properly parsed or interpolated
cstamas
changed the title
cstamas
marked this pull request as ready for review
March 10, 2026 12:51
This comment was marked as outdated.
This comment was marked as outdated.
Member
|
There should be some old PR and issue for that. Did you take a look? AFAIR it was done by either @hboutemy or @rfscholte . |
Member
Author
|
Why would I look for old issue that was done? |
Member
For reference |
slawekjaranowski
approved these changes
Apr 7, 2026
Member
Author
I cannot find any related PR. |
Member
|
@cstamas we the same code in 4.x .... should also be updated? |
Member
Author
|
Yes, once the 'sprint' for 3.10.x is done, we will need forward porting stuff. Same for version filters, it is much improved compared to 4 (inclusion added, h/l is G:A addressable, etc). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem: today in none of Maven 3 is possible to use placeholders and apply interpolation to non-String fields (ie
proxy.activeorproxy.port). Moreover, given Maven is "forgiving" in settings parsing, and only WARNs, it is very easy for user to miss information.This PR:
-Dmaven.settings.strictParsingin user or system properties.Fixes #11011