Skip to content

[MTOOLCHAINS-40] Parent to 36, Maven 3.2.5 and Java 8 - #9

Merged
cstamas merged 1 commit into
masterfrom
update-parent-java8
Jun 17, 2022
Merged

[MTOOLCHAINS-40] Parent to 36, Maven 3.2.5 and Java 8#9
cstamas merged 1 commit into
masterfrom
update-parent-java8

Conversation

@cstamas

@cstamas cstamas commented Jun 17, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

Update project:

  • update parent POM 36
  • update to Maven 3.2.5
  • make it Java8

https://issues.apache.org/jira/browse/MTOOLCHAINS-40

@cstamas
[MTOOLCHAINS-40] Parent to 36 and Java 8
47d8cfb 
Update project:
* use parent POM 36
* make it Java8
@cstamas
cstamas requested a review from michael-o June 17, 2022 11:29
@cstamas cstamas self-assigned this Jun 17, 2022
michael-o
michael-o requested changes Jun 17, 2022
View reviewed changes

@michael-o michael-o left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also mention the Maven 3.2.5 upgrade.

@cstamas cstamas changed the title [MTOOLCHAINS-40] Parent to 36 and Java 8 [MTOOLCHAINS-40] Parent to 36, Maven 3.2.5 and Java 8 Jun 17, 2022
@cstamas
cstamas requested a review from michael-o June 17, 2022 12:16
@michael-o

michael-o commented Jun 17, 2022

Copy link
Copy Markdown
Member

Don't forget issue and commit summary too!

@cstamas

cstamas commented Jun 17, 2022

Copy link
Copy Markdown
Member Author

Don't forget issue and commit summary too!

Um, I usually reuse PR message for commit message (and is updated) while JIRA issue is updated as well...

@michael-o

michael-o commented Jun 17, 2022

Copy link
Copy Markdown
Member

Don't forget issue and commit summary too!

Um, I usually reuse PR message for commit message (and is updated) while JIRA issue is updated as well...

I can't see it on the commit.

@cstamas

cstamas commented Jun 17, 2022

Copy link
Copy Markdown
Member Author

Don't forget issue and commit summary too!

Um, I usually reuse PR message for commit message (and is updated) while JIRA issue is updated as well...

I can't see it on the commit.

... because I usually reuse PR message for commit message? 😄

@michael-o

michael-o commented Jun 17, 2022

Copy link
Copy Markdown
Member

Don't forget issue and commit summary too!

Um, I usually reuse PR message for commit message (and is updated) while JIRA issue is updated as well...

I can't see it on the commit.

... because I usually reuse PR message for commit message? 😄

Stupid me, you are right.

@cstamas
cstamas merged commit 34cb7f6 into master Jun 17, 2022
@cstamas
cstamas deleted the update-parent-java8 branch June 17, 2022 13:03
@jira-importer

jira-importer commented Jul 2, 2025

Copy link
Copy Markdown

Resolve #74

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@michael-o michael-o michael-o approved these changes

Assignees

@cstamas cstamas

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cstamas @michael-o @jira-importer