Skip to content

StringUtils.chopNewline(''): prevent StringIndexOutOfBoundsException #380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
elharo merged 1 commit into from
Jul 1, 2026
Merged

StringUtils.chopNewline(''): prevent StringIndexOutOfBoundsException #380

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/main/java/org/apache/maven/shared/utils/StringUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -963,6 +963,9 @@ public static String chop(@NonNull String str) {
*/
@NonNull
public static String chopNewline(@NonNull String str) {
if (str.isEmpty()) {
return "";
}
int lastIdx = str.length() - 1;
char last = str.charAt(lastIdx);
if (last == '\n') {
Expand Down
5 changes: 5 additions & 0 deletions src/test/java/org/apache/maven/shared/utils/StringUtilsTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -250,6 +250,11 @@ public void testChopNewline() {
assertEquals("dings\n\r", StringUtils.chopNewline("dings\n\r"));
}

@Test
public void testChopNewlineEmptyString() {
assertEquals("", StringUtils.chopNewline(""));
}

@Test
public void testClean() {
assertEquals("", StringUtils.clean(null));
Expand Down
Loading