Skip to content

Move off from deprecated library - #371

Closed
cstamas wants to merge 1 commit into
masterfrom
jline
Closed

Move off from deprecated library#371
cstamas wants to merge 1 commit into
masterfrom
jline

Conversation

@cstamas

@cstamas cstamas commented Mar 11, 2026

Copy link
Copy Markdown
Member

And move onto org.jline:jansi instead that is actively maintained.

And move onto org.jline:jansi instead that
is actively maintained.
@cstamas
cstamas requested review from elharo and slachiewicz March 11, 2026 10:40
@cstamas cstamas self-assigned this Mar 11, 2026
@cstamas cstamas added the dependencies Pull requests that update a dependency file label Mar 11, 2026
cstamas added a commit to cstamas/maven that referenced this pull request Mar 11, 2026
And use maintained org.jline:jansi instead

Depends on:
apache/maven-shared-utils#371
@cstamas

cstamas commented Mar 11, 2026

Copy link
Copy Markdown
Member Author

This library remains part of old Maven 3 ecosystem forever. Maven 4 is on JLine already.

@cstamas cstamas closed this Mar 11, 2026
@cstamas
cstamas deleted the jline branch March 11, 2026 11:15
@elharo

elharo commented Mar 11, 2026

Copy link
Copy Markdown
Contributor

not sure why we need to keep this for Maven 3?

@cstamas

cstamas commented Mar 11, 2026

Copy link
Copy Markdown
Member Author

Because the old library is exported artifact and exported package by Maven Core:
https://github.com/apache/maven/pull/11785/changes#diff-b76b580d9f114f031c237a133170d81d40ead39ddecd91b576f40c2139e31ba0

Hence, doing this sort of a breakage (ie between 3.9.x and 3.10.x) could result that some plugins would work with 3.9.x but not with 3.10.x and other way around, and even worse, may require extra burden for Maven 4 that supports Maven 3 to support this or that or both.

Best to have 3.10.x "smooth sailing", and just keep this (deprecated) library as dependency, as 4 is coming anyway.

@elharo

elharo commented Mar 11, 2026

Copy link
Copy Markdown
Contributor

Makes sense, or at least why you're closing this makes sense. Can't say I agree with the original decision to export this artifact but that ship sailed long ago. Dependencies == pain.

boolean jansi = true;
try {
// Jansi is provided by Maven core since 3.5.0
Class.forName("org.fusesource.jansi.Ansi");

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here we should look for both versions - as we may run on old Maven also

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants