Skip to content

Prefer StringBuilder for local variables #368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
elharo merged 2 commits into from
Feb 6, 2026
Merged

Prefer StringBuilder for local variables #368

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7a5a21b
Prefer StringBuilder for local variables
elharo Feb 4, 2026
518430a
StringBuilder
elharo Feb 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/main/java/org/apache/maven/shared/utils/StringUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1321,7 +1321,7 @@ public static String uncapitalise(String str) {
if (length == 0) {
return "";
} else {
return new StringBuffer(length)
return new StringBuilder(length)
.append(Character.toLowerCase(str.charAt(0)))
.append(str, 1, length)
.toString();
Expand Down Expand Up @@ -1723,7 +1723,7 @@ public static String reverse(String str) {
if (str == null) {
return null;
}
return new StringBuffer(str).reverse().toString();
return new StringBuilder(str).reverse().toString();
}

/**
Expand Down
4 changes: 2 additions & 2 deletions src/main/java/org/apache/maven/shared/utils/xml/XmlWriterUtil.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,7 +206,7 @@ public static void writeComment(XMLWriter writer, String comment, int indent, in
int magicNumber = indentation.length() + columnSize - "-->".length() - 1;
String[] sentences = StringUtils.split(comment, CRLF);

StringBuffer line = new StringBuffer(indentation + "<!-- ");
StringBuilder line = new StringBuilder(indentation + "<!-- ");
for (String sentence : sentences) {
String[] words = StringUtils.split(sentence, " ");
for (String word : words) {
Expand All @@ -221,7 +221,7 @@ public static void writeComment(XMLWriter writer, String comment, int indent, in
line.append("-->").append(CRLF);
writer.writeMarkup(line.toString());
}
line = new StringBuffer(indentation + "<!-- ");
line = new StringBuilder(indentation + "<!-- ");
line.append(word).append(' ');
} else {
line.append(word).append(' ');
Expand Down