-
Notifications
You must be signed in to change notification settings - Fork 36
Fix failing integration tests (#442) #499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
elharo
wants to merge
11
commits into
master
Choose a base branch
from
fix/issue-442-failing-integration-tests-rc5
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+20
−21
Draft
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
8f944bf
Fix failing integration tests with Maven 4.0.0-rc-5 (#442)
elharo 6080f4d
Address review comments and fix CI Maven prerequisite mismatch (#442)
elharo d55b841
Fix integration tests by using setter injection for mojo parameters (…
elharo 35b95fc
Remove setter injection workaround; stay on Maven 4.0.0-rc-4 (#442)
elharo 9175610
pin 4.0.0-rc-4
elharo a7d52d0
pin 4.0.0-rc-4
elharo 0567c43
maven-invoker-plugin
elharo 5b383b7
requiredMavenVersion
elharo cb5c9d8
plugin
elharo 19b6436
fix
elharo 56d60d6
Jenkins is borked. Turn it off.
elharo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For compatibility reasons, the parameter can't be removed here, even if it's use is a no-op