Align PR template (3.x) - #498
Open
Bukama wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Aligns the repository pull request template with the 3.x checklist expectations, focusing on clearer contributor guidance and updated verification steps.
Changes:
- Simplifies and reorders the contributor checklist items (single-issue focus, description quality, commit guidance).
- Adds explicit guidance to include unit tests for behavioral changes.
- Updates suggested Maven commands for basic and integration test verification.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). | ||
|
|
||
| - [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) |
elharo
requested changes
Aug 1, 2026
| @@ -1,29 +1,23 @@ | |||
| Following this checklist to help us incorporate your | |||
| Following this checklist to help us incorporate your | |||
Contributor
There was a problem hiding this comment.
Follow this checklist to help us
| - [ ] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will | ||
| be performed on your pull request automatically. | ||
| - [ ] You have run the integration tests successfully (`mvn -Prun-its clean verify`). | ||
| - [ ] Your pull request should address just one issue, without pulling in other changes. |
| be performed on your pull request automatically. | ||
| - [ ] You have run the integration tests successfully (`mvn -Prun-its clean verify`). | ||
| - [ ] Your pull request should address just one issue, without pulling in other changes. | ||
| - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. |
| - [ ] You have run the integration tests successfully (`mvn -Prun-its clean verify`). | ||
| - [ ] Your pull request should address just one issue, without pulling in other changes. | ||
| - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. | ||
| - [ ] Each commit in the pull request should have a meaningful subject line and body. |
| - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. | ||
| - [ ] Each commit in the pull request should have a meaningful subject line and body. | ||
| Note that commits might be squashed by a maintainer on merge. | ||
| - [ ] Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied. |
| This may not always be possible but is a best-practice. | ||
| - [ ] Run `mvn verify` to make sure basic checks pass. | ||
| A more thorough check will be performed on your pull request automatically. | ||
| - [ ] You have run the integration tests successfully (`mvn -Prun-its verify`). |
Contributor
There was a problem hiding this comment.
Run the integration tests successfully (mvn -Prun-its verify).
| To make clear that you license your contribution under | ||
| To make clear that you license your contribution under | ||
| the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) | ||
| you have to acknowledge this by using the following check-box. |
Contributor
There was a problem hiding this comment.
you have to acknowledge this by using --> check
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.