Skip to content

[MSHARED-1298] Missing site report should be detected - #19

Merged
asfgit merged 1 commit into
masterfrom
MSHARED-1298
Oct 2, 2023
Merged

[MSHARED-1298] Missing site report should be detected#19
asfgit merged 1 commit into
masterfrom
MSHARED-1298

Conversation

@michael-o

Copy link
Copy Markdown
Member

This closes #19

Output:

[INFO] Configuring report plugin maven-plugin-plugin:3.9.0
[WARNING] Ignoring org.apache.maven.plugins:maven-plugin-plugin:3.9.0:addPluginArtifactMetadata goal since it is not a report: should be removed from reporting configuration in POM
[WARNING] Ignoring org.apache.maven.plugins:maven-plugin-plugin:3.9.0:descriptor goal since it is not a report: should be removed from reporting configuration in POM
[WARNING] Ignoring org.apache.maven.plugins:maven-plugin-plugin:3.9.0:help goal since it is not a report: should be removed from reporting configuration in POM
[WARNING] Ignoring org.apache.maven.plugins:maven-plugin-plugin:3.9.0:helpmojo goal since it is not a report: should be removed from reporting configuration in POM

@michael-o

Copy link
Copy Markdown
Member Author

I believe that this is incomplete, I need to test it..

@michael-o
michael-o marked this pull request as draft October 2, 2023 07:52
@slawekjaranowski

Copy link
Copy Markdown
Member

What will be reported if we use plugin which contains usual Mojos and report Mojo?
Like: m-invoker-p

@michael-o

Copy link
Copy Markdown
Member Author

What will be reported if we use plugin which contains usual Mojos and report Mojo? Like: m-invoker-p

Correct, that is the case I am investigating now.

@michael-o

Copy link
Copy Markdown
Member Author

Cases:

  • Non-existing goal: is already covered and exception is thrown
  • no report set: contains both non-report and report goals
  • no report set: contains only non-report goals

@michael-o
michael-o marked this pull request as ready for review October 2, 2023 20:52
@michael-o

Copy link
Copy Markdown
Member Author

@slawekjaranowski, this new change is much better:

[INFO] --- maven-site-plugin:4.0.0-M8:site (default-site) @ report-config ---
[INFO] Configuring report plugin maven-project-info-reports-plugin:3.4.5
[INFO] Configured 1 report for maven-project-info-reports-plugin:3.4.5: index
[INFO] Configuring report plugin maven-plugin-plugin:3.9.0
[WARNING] Ignoring report plugin maven-plugin-plugin:3.9.0, it does not contain any report goals: should be removed from reporting configuration in POM
[INFO] Configuring report plugin maven-pmd-plugin:4.0.0-M1-SNAPSHOT
[INFO] Detected 2 reports for maven-pmd-plugin:4.0.0-M1-SNAPSHOT: cpd, pmd

@asfgit asfgit closed this in 21bb340 Oct 2, 2023
@asfgit
asfgit merged commit 21bb340 into master Oct 2, 2023
@michael-o
michael-o deleted the MSHARED-1298 branch October 2, 2023 22:01
@jira-importer

Copy link
Copy Markdown

Resolve #109

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants