[MSHARED-1024] Replace deprecated code

[michael-o]

This closes #2

[basil]

FYI this breaks binary compatibility with https://github.com/kohsuke/maven-jellydoc-plugin and https://github.com/jenkinsci/maven-stapler-plugin:

jenkins-infra/helpdesk#3049 (comment)

But I suppose we are long past the point where such binary compatibility could reasonably be expected. I will try to update the consumers.

[michael-o]

FYI this breaks binary compatibility with https://github.com/kohsuke/maven-jellydoc-plugin and https://github.com/jenkinsci/maven-stapler-plugin:

jenkins-infra/helpdesk#3049 (comment)

But I suppose we are long past the point where such binary compatibility could reasonably be expected. I will try to update the consumers.

That's true, but is a major and we have to remove at some point. Those methods were deprecated for a long time.

[basil]

Was this breaking change documented in any release notes?

[michael-o]

I need to revert my previous statement because I had another release in memory. Yes, this change was partially wrong and I haven't anticipated people still using 10 years old deprecated interfaces. It should have happened only in a new major version. Although I am still surprised that code even being deprecated and the IDE tells you the successor is still not changed. BTW, same happened with Asciidoctor Maven Plugin. Sorry for the inconvenience.

[michael-o]

Would you prefer a patch release with a revert? This code will go away in 4.0.0 anyway.

[basil]

Thanks Michael, that would definitely be appreciated as otherwise I need to go obtaining write access to two ancient Maven plugins to modernize them and perform new releases, which I would rather not rush to do.

[michael-o]

Thanks Michael, that would definitely be appreciated as otherwise I need to go obtaining write access to two ancient Maven plugins to modernize them and perform new releases, which I would rather not rush to do.

That would only be an interims solution because with Maven Site Plugin 4 they will fail anyway. Please file an issue with MSHARED and link this conversation to it.

[jira-importer]

Resolve #29