Skip to content

Make mcompiler-120 IT locale independent#1063

Open
anilvdl wants to merge 1 commit into
apache:maven-compiler-plugin-3.xfrom
anilvdl:mcompiler-120-locale-independent-it
Open

Make mcompiler-120 IT locale independent#1063
anilvdl wants to merge 1 commit into
apache:maven-compiler-plugin-3.xfrom
anilvdl:mcompiler-120-locale-independent-it

Conversation

@anilvdl

@anilvdl anilvdl commented Jun 22, 2026

Copy link
Copy Markdown

Fix #1055 - Make IT mcompiler-120 locale-agnostic

What: Replace the locale-dependent verbatim assertion in src/it/mcompiler-120/verify.groovy with locale-independent keyword checks.

Why: The IT asserts unchecked call to add(E) as a member of the raw type, which is the English javac diagnostic. On non-English locales (e.g. German: "nicht geprüfter Aufruf von add(E) als Mitglied des Raw-Typs List") this assertion fails, making the IT pass only under English.

How: Replace the full English message check with two keyword assertions (add(E) and List) that appear in every locale because they are type/method tokens substituted into the localized template, not translated text. The existing Compilation failure and invalid flag guards are retained. This mirrors the approach already applied to the same IT on master.

No production code is changed. Only the IT verification script is touched.

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Your pull request should address just one issue, without pulling in other changes.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Each commit in the pull request should have a meaningful subject line and body.
    Note that commits might be squashed by a maintainer on merge.
  • Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied.
    This may not always be possible but is a best-practice.
    N/A. This is an IT-only fix with no runtime changes. The IT itself is the test.
  • Run mvn verify to make sure basic checks pass.
    A more thorough check will be performed on your pull request automatically.
  • You have run the integration tests successfully (mvn -Prun-its verify).

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

The verify script checked the full English warning text, so the IT
failed under non-English locales. Check for a few stable keywords
instead.

Fixes apache#1055
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant